cpu.cc revision 8818
12789Sktlim@umich.edu/*
28733Sgeoffrey.blake@arm.com * Copyright (c) 2011 ARM Limited
38733Sgeoffrey.blake@arm.com * All rights reserved
48733Sgeoffrey.blake@arm.com *
58733Sgeoffrey.blake@arm.com * The license below extends only to copyright in the software and shall
68733Sgeoffrey.blake@arm.com * not be construed as granting a license to any other intellectual
78733Sgeoffrey.blake@arm.com * property including but not limited to intellectual property relating
88733Sgeoffrey.blake@arm.com * to a hardware implementation of the functionality of the software
98733Sgeoffrey.blake@arm.com * licensed hereunder.  You may use the software subject to the license
108733Sgeoffrey.blake@arm.com * terms below provided that you ensure that this notice is replicated
118733Sgeoffrey.blake@arm.com * unmodified and in its entirety in all distributions of the software,
128733Sgeoffrey.blake@arm.com * modified or unmodified, in source code or in binary form.
138733Sgeoffrey.blake@arm.com *
142789Sktlim@umich.edu * Copyright (c) 2006 The Regents of The University of Michigan
152789Sktlim@umich.edu * All rights reserved.
162789Sktlim@umich.edu *
172789Sktlim@umich.edu * Redistribution and use in source and binary forms, with or without
182789Sktlim@umich.edu * modification, are permitted provided that the following conditions are
192789Sktlim@umich.edu * met: redistributions of source code must retain the above copyright
202789Sktlim@umich.edu * notice, this list of conditions and the following disclaimer;
212789Sktlim@umich.edu * redistributions in binary form must reproduce the above copyright
222789Sktlim@umich.edu * notice, this list of conditions and the following disclaimer in the
232789Sktlim@umich.edu * documentation and/or other materials provided with the distribution;
242789Sktlim@umich.edu * neither the name of the copyright holders nor the names of its
252789Sktlim@umich.edu * contributors may be used to endorse or promote products derived from
262789Sktlim@umich.edu * this software without specific prior written permission.
272789Sktlim@umich.edu *
282789Sktlim@umich.edu * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
292789Sktlim@umich.edu * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
302789Sktlim@umich.edu * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
312789Sktlim@umich.edu * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
322789Sktlim@umich.edu * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
332789Sktlim@umich.edu * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
342789Sktlim@umich.edu * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
352789Sktlim@umich.edu * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
362789Sktlim@umich.edu * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
372789Sktlim@umich.edu * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
382789Sktlim@umich.edu * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
392789Sktlim@umich.edu *
402789Sktlim@umich.edu * Authors: Kevin Lim
418733Sgeoffrey.blake@arm.com *          Geoffrey Blake
422789Sktlim@umich.edu */
432789Sktlim@umich.edu
442789Sktlim@umich.edu#include <list>
452789Sktlim@umich.edu#include <string>
462789Sktlim@umich.edu
478793Sgblack@eecs.umich.edu#include "arch/kernel_stats.hh"
488793Sgblack@eecs.umich.edu#include "arch/vtophys.hh"
498229Snate@binkert.org#include "cpu/checker/cpu.hh"
502789Sktlim@umich.edu#include "cpu/base.hh"
512789Sktlim@umich.edu#include "cpu/simple_thread.hh"
523348Sbinkertn@umich.edu#include "cpu/static_inst.hh"
532789Sktlim@umich.edu#include "cpu/thread_context.hh"
548733Sgeoffrey.blake@arm.com#include "params/CheckerCPU.hh"
558733Sgeoffrey.blake@arm.com#include "sim/tlb.hh"
562789Sktlim@umich.edu
572789Sktlim@umich.eduusing namespace std;
588733Sgeoffrey.blake@arm.comusing namespace TheISA;
592789Sktlim@umich.edu
602789Sktlim@umich.eduvoid
612789Sktlim@umich.eduCheckerCPU::init()
622789Sktlim@umich.edu{
632789Sktlim@umich.edu}
642789Sktlim@umich.edu
652789Sktlim@umich.eduCheckerCPU::CheckerCPU(Params *p)
662789Sktlim@umich.edu    : BaseCPU(p), thread(NULL), tc(NULL)
672789Sktlim@umich.edu{
682789Sktlim@umich.edu    memReq = NULL;
698733Sgeoffrey.blake@arm.com    curStaticInst = NULL;
708733Sgeoffrey.blake@arm.com    curMacroStaticInst = NULL;
712789Sktlim@umich.edu
722789Sktlim@umich.edu    numInst = 0;
732789Sktlim@umich.edu    startNumInst = 0;
742789Sktlim@umich.edu    numLoad = 0;
752789Sktlim@umich.edu    startNumLoad = 0;
762789Sktlim@umich.edu    youngestSN = 0;
772789Sktlim@umich.edu
782789Sktlim@umich.edu    changedPC = willChangePC = changedNextPC = false;
792789Sktlim@umich.edu
802789Sktlim@umich.edu    exitOnError = p->exitOnError;
812789Sktlim@umich.edu    warnOnlyOnLoadError = p->warnOnlyOnLoadError;
822789Sktlim@umich.edu    itb = p->itb;
832789Sktlim@umich.edu    dtb = p->dtb;
842789Sktlim@umich.edu    systemPtr = NULL;
858733Sgeoffrey.blake@arm.com    workload = p->workload;
868733Sgeoffrey.blake@arm.com    // XXX: This is a hack to get this to work some
878818Sgblack@eecs.umich.edu    thread = new SimpleThread(this, /* thread_num */ 0,
888818Sgblack@eecs.umich.edu            workload.size() ? workload[0] : NULL, itb, dtb);
893402Sktlim@umich.edu
903402Sktlim@umich.edu    tc = thread->getTC();
913402Sktlim@umich.edu    threadContexts.push_back(tc);
922789Sktlim@umich.edu
938733Sgeoffrey.blake@arm.com    updateOnError = true;
942789Sktlim@umich.edu}
952789Sktlim@umich.edu
962789Sktlim@umich.eduCheckerCPU::~CheckerCPU()
972789Sktlim@umich.edu{
982789Sktlim@umich.edu}
992789Sktlim@umich.edu
1002789Sktlim@umich.eduvoid
1012789Sktlim@umich.eduCheckerCPU::setSystem(System *system)
1022789Sktlim@umich.edu{
1032789Sktlim@umich.edu    systemPtr = system;
1042789Sktlim@umich.edu
1052789Sktlim@umich.edu    thread = new SimpleThread(this, 0, systemPtr, itb, dtb, false);
1062789Sktlim@umich.edu
1072789Sktlim@umich.edu    tc = thread->getTC();
1082789Sktlim@umich.edu    threadContexts.push_back(tc);
1092789Sktlim@umich.edu    delete thread->kernelStats;
1102789Sktlim@umich.edu    thread->kernelStats = NULL;
1112789Sktlim@umich.edu}
1122789Sktlim@umich.edu
1132789Sktlim@umich.eduvoid
1142789Sktlim@umich.eduCheckerCPU::setIcachePort(Port *icache_port)
1152789Sktlim@umich.edu{
1162789Sktlim@umich.edu    icachePort = icache_port;
1172789Sktlim@umich.edu}
1182789Sktlim@umich.edu
1192789Sktlim@umich.eduvoid
1202789Sktlim@umich.eduCheckerCPU::setDcachePort(Port *dcache_port)
1212789Sktlim@umich.edu{
1222789Sktlim@umich.edu    dcachePort = dcache_port;
1232789Sktlim@umich.edu}
1242789Sktlim@umich.edu
1252789Sktlim@umich.eduvoid
1262789Sktlim@umich.eduCheckerCPU::serialize(ostream &os)
1272789Sktlim@umich.edu{
1282789Sktlim@umich.edu}
1292789Sktlim@umich.edu
1302789Sktlim@umich.eduvoid
1312789Sktlim@umich.eduCheckerCPU::unserialize(Checkpoint *cp, const string &section)
1322789Sktlim@umich.edu{
1332789Sktlim@umich.edu}
1342789Sktlim@umich.edu
1352789Sktlim@umich.eduFault
1368733Sgeoffrey.blake@arm.comCheckerCPU::readMem(Addr addr, uint8_t *data, unsigned size, unsigned flags)
1372789Sktlim@umich.edu{
1388733Sgeoffrey.blake@arm.com    Fault fault = NoFault;
1398733Sgeoffrey.blake@arm.com    unsigned blockSize = dcachePort->peerBlockSize();
1408733Sgeoffrey.blake@arm.com    int fullSize = size;
1418733Sgeoffrey.blake@arm.com    Addr secondAddr = roundDown(addr + size - 1, blockSize);
1428733Sgeoffrey.blake@arm.com    bool checked_flags = false;
1438733Sgeoffrey.blake@arm.com    bool flags_match = true;
1448733Sgeoffrey.blake@arm.com    Addr pAddr = 0x0;
1452789Sktlim@umich.edu
1462789Sktlim@umich.edu
1478733Sgeoffrey.blake@arm.com    if (secondAddr > addr)
1488733Sgeoffrey.blake@arm.com       size = secondAddr - addr;
1492789Sktlim@umich.edu
1508733Sgeoffrey.blake@arm.com    // Need to account for multiple accesses like the Atomic and TimingSimple
1518733Sgeoffrey.blake@arm.com    while (1) {
1528733Sgeoffrey.blake@arm.com        memReq = new Request();
1538733Sgeoffrey.blake@arm.com        memReq->setVirt(0, addr, size, flags, thread->pcState().instAddr());
1542789Sktlim@umich.edu
1558733Sgeoffrey.blake@arm.com        // translate to physical address
1568733Sgeoffrey.blake@arm.com        fault = dtb->translateFunctional(memReq, tc, BaseTLB::Read);
1572789Sktlim@umich.edu
1588733Sgeoffrey.blake@arm.com        if (!checked_flags && fault == NoFault && unverifiedReq) {
1598733Sgeoffrey.blake@arm.com            flags_match = checkFlags(unverifiedReq, memReq->getVaddr(),
1608733Sgeoffrey.blake@arm.com                                     memReq->getPaddr(), memReq->getFlags());
1618733Sgeoffrey.blake@arm.com            pAddr = memReq->getPaddr();
1628733Sgeoffrey.blake@arm.com            checked_flags = true;
1638733Sgeoffrey.blake@arm.com        }
1648733Sgeoffrey.blake@arm.com
1658733Sgeoffrey.blake@arm.com        // Now do the access
1668733Sgeoffrey.blake@arm.com        if (fault == NoFault &&
1678733Sgeoffrey.blake@arm.com            !memReq->getFlags().isSet(Request::NO_ACCESS)) {
1688733Sgeoffrey.blake@arm.com            PacketPtr pkt = new Packet(memReq,
1698733Sgeoffrey.blake@arm.com                              memReq->isLLSC() ?
1708733Sgeoffrey.blake@arm.com                              MemCmd::LoadLockedReq : MemCmd::ReadReq,
1718733Sgeoffrey.blake@arm.com                              Packet::Broadcast);
1728733Sgeoffrey.blake@arm.com
1738733Sgeoffrey.blake@arm.com            pkt->dataStatic(data);
1748733Sgeoffrey.blake@arm.com
1758733Sgeoffrey.blake@arm.com            if (!(memReq->isUncacheable() || memReq->isMmappedIpr())) {
1768733Sgeoffrey.blake@arm.com                // Access memory to see if we have the same data
1778733Sgeoffrey.blake@arm.com                dcachePort->sendFunctional(pkt);
1788733Sgeoffrey.blake@arm.com            } else {
1798733Sgeoffrey.blake@arm.com                // Assume the data is correct if it's an uncached access
1808733Sgeoffrey.blake@arm.com                memcpy(data, unverifiedMemData, size);
1818733Sgeoffrey.blake@arm.com            }
1828733Sgeoffrey.blake@arm.com
1838733Sgeoffrey.blake@arm.com            delete memReq;
1848733Sgeoffrey.blake@arm.com            memReq = NULL;
1858733Sgeoffrey.blake@arm.com            delete pkt;
1868733Sgeoffrey.blake@arm.com        }
1878733Sgeoffrey.blake@arm.com
1888733Sgeoffrey.blake@arm.com        if (fault != NoFault) {
1898733Sgeoffrey.blake@arm.com            if (memReq->isPrefetch()) {
1908733Sgeoffrey.blake@arm.com                fault = NoFault;
1918733Sgeoffrey.blake@arm.com            }
1928733Sgeoffrey.blake@arm.com            delete memReq;
1938733Sgeoffrey.blake@arm.com            memReq = NULL;
1948733Sgeoffrey.blake@arm.com            break;
1958733Sgeoffrey.blake@arm.com        }
1968733Sgeoffrey.blake@arm.com
1978733Sgeoffrey.blake@arm.com        if (memReq != NULL) {
1988733Sgeoffrey.blake@arm.com            delete memReq;
1998733Sgeoffrey.blake@arm.com        }
2008733Sgeoffrey.blake@arm.com
2018733Sgeoffrey.blake@arm.com        //If we don't need to access a second cache line, stop now.
2028733Sgeoffrey.blake@arm.com        if (secondAddr <= addr)
2038733Sgeoffrey.blake@arm.com        {
2048733Sgeoffrey.blake@arm.com            break;
2058733Sgeoffrey.blake@arm.com        }
2068733Sgeoffrey.blake@arm.com
2078733Sgeoffrey.blake@arm.com        // Setup for accessing next cache line
2088733Sgeoffrey.blake@arm.com        data += size;
2098733Sgeoffrey.blake@arm.com        unverifiedMemData += size;
2108733Sgeoffrey.blake@arm.com        size = addr + fullSize - secondAddr;
2118733Sgeoffrey.blake@arm.com        addr = secondAddr;
2122789Sktlim@umich.edu    }
2132789Sktlim@umich.edu
2148733Sgeoffrey.blake@arm.com    if (!flags_match) {
2158733Sgeoffrey.blake@arm.com        warn("%lli: Flags do not match CPU:%#x %#x %#x Checker:%#x %#x %#x\n",
2168733Sgeoffrey.blake@arm.com             curTick(), unverifiedReq->getVaddr(), unverifiedReq->getPaddr(),
2178733Sgeoffrey.blake@arm.com             unverifiedReq->getFlags(), addr, pAddr, flags);
2188733Sgeoffrey.blake@arm.com        handleError();
2198733Sgeoffrey.blake@arm.com    }
2202789Sktlim@umich.edu
2218733Sgeoffrey.blake@arm.com    return fault;
2222789Sktlim@umich.edu}
2232789Sktlim@umich.edu
2248733Sgeoffrey.blake@arm.comFault
2258733Sgeoffrey.blake@arm.comCheckerCPU::writeMem(uint8_t *data, unsigned size,
2268733Sgeoffrey.blake@arm.com                     Addr addr, unsigned flags, uint64_t *res)
2278733Sgeoffrey.blake@arm.com{
2288733Sgeoffrey.blake@arm.com    Fault fault = NoFault;
2298733Sgeoffrey.blake@arm.com    bool checked_flags = false;
2308733Sgeoffrey.blake@arm.com    bool flags_match = true;
2318733Sgeoffrey.blake@arm.com    Addr pAddr = 0x0;
2322789Sktlim@umich.edu
2338733Sgeoffrey.blake@arm.com    unsigned blockSize = dcachePort->peerBlockSize();
2348733Sgeoffrey.blake@arm.com    int fullSize = size;
2352789Sktlim@umich.edu
2368733Sgeoffrey.blake@arm.com    Addr secondAddr = roundDown(addr + size - 1, blockSize);
2372789Sktlim@umich.edu
2388733Sgeoffrey.blake@arm.com    if (secondAddr > addr)
2398733Sgeoffrey.blake@arm.com        size = secondAddr - addr;
2402789Sktlim@umich.edu
2418733Sgeoffrey.blake@arm.com    // Need to account for a multiple access like Atomic and Timing CPUs
2428733Sgeoffrey.blake@arm.com    while (1) {
2438733Sgeoffrey.blake@arm.com        memReq = new Request();
2448733Sgeoffrey.blake@arm.com        memReq->setVirt(0, addr, size, flags, thread->pcState().instAddr());
2452789Sktlim@umich.edu
2468733Sgeoffrey.blake@arm.com        // translate to physical address
2478733Sgeoffrey.blake@arm.com        fault = dtb->translateFunctional(memReq, tc, BaseTLB::Write);
2482789Sktlim@umich.edu
2498733Sgeoffrey.blake@arm.com        if (!checked_flags && fault == NoFault && unverifiedReq) {
2508733Sgeoffrey.blake@arm.com           flags_match = checkFlags(unverifiedReq, memReq->getVaddr(),
2518733Sgeoffrey.blake@arm.com                                    memReq->getPaddr(), memReq->getFlags());
2528733Sgeoffrey.blake@arm.com           pAddr = memReq->getPaddr();
2538733Sgeoffrey.blake@arm.com           checked_flags = true;
2548733Sgeoffrey.blake@arm.com        }
2558733Sgeoffrey.blake@arm.com
2568733Sgeoffrey.blake@arm.com        /*
2578733Sgeoffrey.blake@arm.com         * We don't actually check memory for the store because there
2588733Sgeoffrey.blake@arm.com         * is no guarantee it has left the lsq yet, and therefore we
2598733Sgeoffrey.blake@arm.com         * can't verify the memory on stores without lsq snooping
2608733Sgeoffrey.blake@arm.com         * enabled.  This is left as future work for the Checker: LSQ snooping
2618733Sgeoffrey.blake@arm.com         * and memory validation after stores have committed.
2628733Sgeoffrey.blake@arm.com         */
2638733Sgeoffrey.blake@arm.com
2648733Sgeoffrey.blake@arm.com        delete memReq;
2658733Sgeoffrey.blake@arm.com
2668733Sgeoffrey.blake@arm.com        //If we don't need to access a second cache line, stop now.
2678733Sgeoffrey.blake@arm.com        if (fault != NoFault || secondAddr <= addr)
2688733Sgeoffrey.blake@arm.com        {
2698733Sgeoffrey.blake@arm.com            if (fault != NoFault && memReq->isPrefetch()) {
2708733Sgeoffrey.blake@arm.com              fault = NoFault;
2718733Sgeoffrey.blake@arm.com            }
2728733Sgeoffrey.blake@arm.com            break;
2738733Sgeoffrey.blake@arm.com        }
2748733Sgeoffrey.blake@arm.com
2758733Sgeoffrey.blake@arm.com        //Update size and access address
2768733Sgeoffrey.blake@arm.com        size = addr + fullSize - secondAddr;
2778733Sgeoffrey.blake@arm.com        //And access the right address.
2788733Sgeoffrey.blake@arm.com        addr = secondAddr;
2798733Sgeoffrey.blake@arm.com   }
2808733Sgeoffrey.blake@arm.com
2818733Sgeoffrey.blake@arm.com   if (!flags_match) {
2828733Sgeoffrey.blake@arm.com       warn("%lli: Flags do not match CPU:%#x %#x Checker:%#x %#x %#x\n",
2838733Sgeoffrey.blake@arm.com            curTick(), unverifiedReq->getVaddr(), unverifiedReq->getPaddr(),
2848733Sgeoffrey.blake@arm.com            unverifiedReq->getFlags(), addr, pAddr, flags);
2858733Sgeoffrey.blake@arm.com       handleError();
2868733Sgeoffrey.blake@arm.com   }
2878733Sgeoffrey.blake@arm.com
2888733Sgeoffrey.blake@arm.com   // Assume the result was the same as the one passed in.  This checker
2898733Sgeoffrey.blake@arm.com   // doesn't check if the SC should succeed or fail, it just checks the
2908733Sgeoffrey.blake@arm.com   // value.
2918733Sgeoffrey.blake@arm.com   if (unverifiedReq && res && unverifiedReq->extraDataValid())
2928733Sgeoffrey.blake@arm.com       *res = unverifiedReq->getExtraData();
2938733Sgeoffrey.blake@arm.com
2948733Sgeoffrey.blake@arm.com   // Entire purpose here is to make sure we are getting the
2958733Sgeoffrey.blake@arm.com   // same data to send to the mem system as the CPU did.
2968733Sgeoffrey.blake@arm.com   // Cannot check this is actually what went to memory because
2978733Sgeoffrey.blake@arm.com   // there stores can be in ld/st queue or coherent operations
2988733Sgeoffrey.blake@arm.com   // overwriting values.
2998733Sgeoffrey.blake@arm.com   bool extraData;
3008733Sgeoffrey.blake@arm.com   if (unverifiedReq) {
3018733Sgeoffrey.blake@arm.com       extraData = unverifiedReq->extraDataValid() ?
3028733Sgeoffrey.blake@arm.com                        unverifiedReq->getExtraData() : 1;
3038733Sgeoffrey.blake@arm.com   }
3048733Sgeoffrey.blake@arm.com
3058733Sgeoffrey.blake@arm.com   if (unverifiedReq && unverifiedMemData &&
3068733Sgeoffrey.blake@arm.com       memcmp(data, unverifiedMemData, fullSize) && extraData) {
3078733Sgeoffrey.blake@arm.com           warn("%lli: Store value does not match value sent to memory!\
3088733Sgeoffrey.blake@arm.com                  data: %#x inst_data: %#x", curTick(), data,
3098733Sgeoffrey.blake@arm.com                  unverifiedMemData);
3108733Sgeoffrey.blake@arm.com       handleError();
3118733Sgeoffrey.blake@arm.com   }
3128733Sgeoffrey.blake@arm.com
3138733Sgeoffrey.blake@arm.com   return fault;
3142789Sktlim@umich.edu}
3152789Sktlim@umich.edu
3162789Sktlim@umich.eduAddr
3172789Sktlim@umich.eduCheckerCPU::dbg_vtophys(Addr addr)
3182789Sktlim@umich.edu{
3192789Sktlim@umich.edu    return vtophys(tc, addr);
3202789Sktlim@umich.edu}
3212789Sktlim@umich.edu
3228733Sgeoffrey.blake@arm.com/**
3238733Sgeoffrey.blake@arm.com * Checks if the flags set by the Checker and Checkee match.
3248733Sgeoffrey.blake@arm.com */
3252789Sktlim@umich.edubool
3268733Sgeoffrey.blake@arm.comCheckerCPU::checkFlags(Request *unverified_req, Addr vAddr,
3278733Sgeoffrey.blake@arm.com                       Addr pAddr, int flags)
3282789Sktlim@umich.edu{
3298733Sgeoffrey.blake@arm.com    Addr unverifiedVAddr = unverified_req->getVaddr();
3308733Sgeoffrey.blake@arm.com    Addr unverifiedPAddr = unverified_req->getPaddr();
3318733Sgeoffrey.blake@arm.com    int unverifiedFlags = unverified_req->getFlags();
3328733Sgeoffrey.blake@arm.com
3338733Sgeoffrey.blake@arm.com    if (unverifiedVAddr != vAddr ||
3348733Sgeoffrey.blake@arm.com        unverifiedPAddr != pAddr ||
3358733Sgeoffrey.blake@arm.com        unverifiedFlags != flags) {
3362789Sktlim@umich.edu        return false;
3372789Sktlim@umich.edu    }
3388733Sgeoffrey.blake@arm.com
3398733Sgeoffrey.blake@arm.com    return true;
3402789Sktlim@umich.edu}
3412789Sktlim@umich.edu
3422789Sktlim@umich.eduvoid
3432789Sktlim@umich.eduCheckerCPU::dumpAndExit()
3442789Sktlim@umich.edu{
3458733Sgeoffrey.blake@arm.com    warn("%lli: Checker PC:%s",
3468733Sgeoffrey.blake@arm.com         curTick(), thread->pcState());
3472789Sktlim@umich.edu    panic("Checker found an error!");
3482789Sktlim@umich.edu}
349