RubyPort.cc (7023:185ad61a4117) | RubyPort.cc (7035:b78b3a9e205f) |
---|---|
1 2/* 3 * Copyright (c) 2009 Advanced Micro Devices, Inc. 4 * All rights reserved. 5 * 6 * Redistribution and use in source and binary forms, with or without 7 * modification, are permitted provided that the following conditions are 8 * met: redistributions of source code must retain the above copyright --- 216 unchanged lines hidden (view full) --- 225 type = RubyRequestType_IFETCH; 226 } else { 227 type = RubyRequestType_LD; 228 } 229 } else if (pkt->isWrite()) { 230 type = RubyRequestType_ST; 231 } else if (pkt->isReadWrite()) { 232 // | 1 2/* 3 * Copyright (c) 2009 Advanced Micro Devices, Inc. 4 * All rights reserved. 5 * 6 * Redistribution and use in source and binary forms, with or without 7 * modification, are permitted provided that the following conditions are 8 * met: redistributions of source code must retain the above copyright --- 216 unchanged lines hidden (view full) --- 225 type = RubyRequestType_IFETCH; 226 } else { 227 type = RubyRequestType_LD; 228 } 229 } else if (pkt->isWrite()) { 230 type = RubyRequestType_ST; 231 } else if (pkt->isReadWrite()) { 232 // |
233 // Fix me. Just because the packet is a read/write request does not 234 // necessary mean it is a read-modify-write atomic operation. | 233 // Fix me. This conditional will never be executed because 234 // isReadWrite() is just an OR of isRead() and isWrite(). 235 // Furthermore, just because the packet is a read/write request does 236 // not necessary mean it is a read-modify-write atomic operation. |
235 // 236 type = RubyRequestType_RMW_Write; 237 } else { 238 panic("Unsupported ruby packet type\n"); 239 } 240 } 241 242 RubyRequest ruby_request(pkt->getAddr(), --- 118 unchanged lines hidden --- | 237 // 238 type = RubyRequestType_RMW_Write; 239 } else { 240 panic("Unsupported ruby packet type\n"); 241 } 242 } 243 244 RubyRequest ruby_request(pkt->getAddr(), --- 118 unchanged lines hidden --- |