Searched hist:11493 (Results 1 - 1 of 1) sorted by relevance
| /gem5/src/mem/cache/ | ||
| H A D | cache.cc | 11493:06b73eb44660 Thu May 26 06:56:00 EDT 2016 Andreas Hansson <andreas.hansson@arm.com> mem: Fix memory leak in handling of deferred snoops This patch fixes a memory leak where deferred snoop packets never got deallocated. On the call to MSHR::handleSnoop these snoops were treated as if a response will be sent, as the MSHR was pendingModified. Consequently, a copy of the packet was created and added to the MSHR targets. However, an preceeding target to the same MSHR, originally from a CPU, was serviced before the snoop, and caused the block to be invalidated. This happens for ReadExReq and UpgradeReq. Note that the original snoop will receive a response, just not from the cache in question, but instead from the cache upstream that issued the ReadExReq or UpgradeReq. Change-Id: I4ac012fbc8a46cf693ca390fe9476105d444e6f4 Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com> |
Completed in 17 milliseconds