check-style.sh revision 12391:ceeca8b41e4b
11897Sstever@eecs.umich.edu#!/bin/bash 23077Sstever@eecs.umich.edu# 31897Sstever@eecs.umich.edu# Script to check include/test code for common pybind11 code style errors. 41897Sstever@eecs.umich.edu# 51897Sstever@eecs.umich.edu# This script currently checks for 61897Sstever@eecs.umich.edu# 71897Sstever@eecs.umich.edu# 1. use of tabs instead of spaces 81897Sstever@eecs.umich.edu# 2. MSDOS-style CRLF endings 91897Sstever@eecs.umich.edu# 3. trailing spaces 101897Sstever@eecs.umich.edu# 4. missing space between keyword and parenthesis, e.g.: for(, if(, while( 111897Sstever@eecs.umich.edu# 5. Missing space between right parenthesis and brace, e.g. 'for (...){' 121897Sstever@eecs.umich.edu# 6. opening brace on its own line. It should always be on the same line as the 131897Sstever@eecs.umich.edu# if/while/for/do statment. 141897Sstever@eecs.umich.edu# 151897Sstever@eecs.umich.edu# Invoke as: tools/check-style.sh 161897Sstever@eecs.umich.edu# 171897Sstever@eecs.umich.edu 181897Sstever@eecs.umich.educheck_style_errors=0 191897Sstever@eecs.umich.eduIFS=$'\n' 201897Sstever@eecs.umich.edu 211897Sstever@eecs.umich.edufound="$( GREP_COLORS='mt=41' GREP_COLOR='41' grep $'\t' include tests/*.{cpp,py,h} docs/*.rst -rn --color=always )" 221897Sstever@eecs.umich.eduif [ -n "$found" ]; then 231897Sstever@eecs.umich.edu # The mt=41 sets a red background for matched tabs: 241897Sstever@eecs.umich.edu echo -e '\033[31;01mError: found tab characters in the following files:\033[0m' 251897Sstever@eecs.umich.edu check_style_errors=1 261897Sstever@eecs.umich.edu echo "$found" | sed -e 's/^/ /' 271897Sstever@eecs.umich.edufi 281897Sstever@eecs.umich.edu 291897Sstever@eecs.umich.edu 301897Sstever@eecs.umich.edufound="$( grep -IUlr $'\r' include tests/*.{cpp,py,h} docs/*.rst --color=always )" 311897Sstever@eecs.umich.eduif [ -n "$found" ]; then 321897Sstever@eecs.umich.edu echo -e '\033[31;01mError: found CRLF characters in the following files:\033[0m' 331897Sstever@eecs.umich.edu check_style_errors=1 341897Sstever@eecs.umich.edu echo "$found" | sed -e 's/^/ /' 351897Sstever@eecs.umich.edufi 361897Sstever@eecs.umich.edu 371897Sstever@eecs.umich.edufound="$(GREP_COLORS='mt=41' GREP_COLOR='41' grep '[[:blank:]]\+$' include tests/*.{cpp,py,h} docs/*.rst -rn --color=always )" 381897Sstever@eecs.umich.eduif [ -n "$found" ]; then 391897Sstever@eecs.umich.edu # The mt=41 sets a red background for matched trailing spaces 401897Sstever@eecs.umich.edu echo -e '\033[31;01mError: found trailing spaces in the following files:\033[0m' 411897Sstever@eecs.umich.edu check_style_errors=1 421897Sstever@eecs.umich.edu echo "$found" | sed -e 's/^/ /' 431897Sstever@eecs.umich.edufi 441897Sstever@eecs.umich.edu 451897Sstever@eecs.umich.edufound="$(grep '\<\(if\|for\|while\|catch\)(\|){' include tests/*.{cpp,h} -rn --color=always)" 461897Sstever@eecs.umich.eduif [ -n "$found" ]; then 471897Sstever@eecs.umich.edu echo -e '\033[31;01mError: found the following coding style problems:\033[0m' 481897Sstever@eecs.umich.edu check_style_errors=1 491897Sstever@eecs.umich.edu echo "$found" | sed -e 's/^/ /' 501897Sstever@eecs.umich.edufi 511897Sstever@eecs.umich.edu 521897Sstever@eecs.umich.edufound="$(awk ' 533077Sstever@eecs.umich.edufunction prefix(filename, lineno) { 541897Sstever@eecs.umich.edu return " \033[35m" filename "\033[36m:\033[32m" lineno "\033[36m:\033[0m" 551897Sstever@eecs.umich.edu} 561897Sstever@eecs.umich.edufunction mark(pattern, string) { sub(pattern, "\033[01;31m&\033[0m", string); return string } 571897Sstever@eecs.umich.edulast && /^\s*{/ { 581897Sstever@eecs.umich.edu print prefix(FILENAME, FNR-1) mark("\\)\\s*$", last) 591897Sstever@eecs.umich.edu print prefix(FILENAME, FNR) mark("^\\s*{", $0) 601897Sstever@eecs.umich.edu last="" 611897Sstever@eecs.umich.edu} 621897Sstever@eecs.umich.edu{ last = /(if|for|while|catch|switch)\s*\(.*\)\s*$/ ? $0 : "" } 631897Sstever@eecs.umich.edu' $(find include -type f) tests/*.{cpp,h} docs/*.rst)" 641897Sstever@eecs.umich.eduif [ -n "$found" ]; then 651897Sstever@eecs.umich.edu check_style_errors=1 661897Sstever@eecs.umich.edu echo -e '\033[31;01mError: braces should occur on the same line as the if/while/.. statement. Found issues in the following files:\033[0m' 671897Sstever@eecs.umich.edu echo "$found" 681897Sstever@eecs.umich.edufi 691897Sstever@eecs.umich.edu 701897Sstever@eecs.umich.eduexit $check_style_errors 711897Sstever@eecs.umich.edu