Searched hist:13382 (Results 1 - 2 of 2) sorted by relevance
/gem5/src/systemc/ext/core/ | ||
H A D | sc_module.hh | diff 13382:7db1e345834c Fri Nov 02 18:30:00 EDT 2018 Gabe Black <gabeblack@google.com> systemc: Change how SC_BIND_PROXY_NIL is initialized. The previous implementation dereferenced a null pointer to create a reference which would then have its address taken in the sc_bind_proxy constructor. clang says that that uses undefined behavior, so this change adds a default constructor which initializes the two contained pointers to null explicitly. We have to hope systemc code doesn't play around with sc_bind_proxy too much and doesn't accidentally use this constructor unintentionally, but it seems like the least bad possible solution which makes clang happy. Change-Id: Ic59603495fe7a406586a18ce44de979f84089bcd Reviewed-on: https://gem5-review.googlesource.com/c/13879 Reviewed-by: Gabe Black <gabeblack@google.com> Maintainer: Gabe Black <gabeblack@google.com> |
/gem5/src/systemc/core/ | ||
H A D | sc_module.cc | diff 13382:7db1e345834c Fri Nov 02 18:30:00 EDT 2018 Gabe Black <gabeblack@google.com> systemc: Change how SC_BIND_PROXY_NIL is initialized. The previous implementation dereferenced a null pointer to create a reference which would then have its address taken in the sc_bind_proxy constructor. clang says that that uses undefined behavior, so this change adds a default constructor which initializes the two contained pointers to null explicitly. We have to hope systemc code doesn't play around with sc_bind_proxy too much and doesn't accidentally use this constructor unintentionally, but it seems like the least bad possible solution which makes clang happy. Change-Id: Ic59603495fe7a406586a18ce44de979f84089bcd Reviewed-on: https://gem5-review.googlesource.com/c/13879 Reviewed-by: Gabe Black <gabeblack@google.com> Maintainer: Gabe Black <gabeblack@google.com> |
Completed in 27 milliseconds