Searched hist:11603 (Results 1 - 1 of 1) sorted by relevance
| /gem5/src/mem/ | ||
| H A D | snoop_filter.cc | diff 11603:900cca8c5b04 Fri Aug 12 09:11:00 EDT 2016 Andreas Hansson <andreas.hansson@arm.com> mem: Use FromCache attribute in snoop filter allocation This patch improves the snoop filter allocation decisions by not only looking at whether a port is snooping or not, but also if the packet actually came from a cache. The issue with only looking at isSnooping is that the CPU ports, for example, are snooping, but not actually caching. Previously we ended up incorrectly allocating entries in systems without caches (such as the atomic and timing quick regressions). Eventually these misguided allocations caused the snoop filter to panic due to an excessive size. On the request path we now include the fromCache check on the packet itself, and for responses we check if we actually have a snoop-filter entry. Change-Id: Idd2dbc4f00c7e07d331e9a02658aee30d0350d7e Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com> Reviewed-by: Stephan Diestelhorst <stephan.diestelhorst@arm.com> Reviewed-by: Tony Gutierrez <anthony.gutierrez@amd.com> |
Completed in 6 milliseconds