| CONTRIBUTING.md (12847:ed74e3cc9ce9) | CONTRIBUTING.md (12883:9a34863049c2) |
|---|---|
| 1Authors: Jason Lowe-Power 2 Andreas Sandberg 3 Steve Reinhardt 4 5If you've made changes to gem5 that might benefit others, we strongly encourage 6you to contribute those changes to the public gem5 repository. There are 7several reasons to do this: 8 * Share your work with others, so that they can benefit from new functionality. --- 22 unchanged lines hidden (view full) --- 31====================================== 32 33 +-------------+ 34 | Make change | 35 +------+------+ 36 | 37 | 38 v | 1Authors: Jason Lowe-Power 2 Andreas Sandberg 3 Steve Reinhardt 4 5If you've made changes to gem5 that might benefit others, we strongly encourage 6you to contribute those changes to the public gem5 repository. There are 7several reasons to do this: 8 * Share your work with others, so that they can benefit from new functionality. --- 22 unchanged lines hidden (view full) --- 31====================================== 32 33 +-------------+ 34 | Make change | 35 +------+------+ 36 | 37 | 38 v |
| 39 +------+------+ 40 | Post review | 41 +------+------+ 42 | 43 v 44 +--------+---------+ 45 | Wait for reviews | <--------+ | 39 +-------------+ 40 | Run tests |<--------------+ 41 +------+------+ | 42 | | 43 | | 44 v | 45 +------+------+ | 46 | Post review | | 47 +------+------+ | 48 | | 49 v | |
| 46 +--------+---------+ | | 50 +--------+---------+ | |
| 51 | Wait for reviews | | 52 +--------+---------+ | |
|
| 47 | | 48 | | 49 v | 50 +----+----+ No +------+------+ 51 |Reviewers+--------->+ Update code | 52 |happy? | +------+------+ 53 +----+----+ ^ 54 | | --- 118 unchanged lines hidden (view full) --- 173If this happens, update your changeset descriptions to match the required style 174and resubmit. The following is a useful git command to update the most recent 175commit (HEAD). 176 177``` 178 git commit --amend 179``` 180 | 53 | | 54 | | 55 v | 56 +----+----+ No +------+------+ 57 |Reviewers+--------->+ Update code | 58 |happy? | +------+------+ 59 +----+----+ ^ 60 | | --- 118 unchanged lines hidden (view full) --- 179If this happens, update your changeset descriptions to match the required style 180and resubmit. The following is a useful git command to update the most recent 181commit (HEAD). 182 183``` 184 git commit --amend 185``` 186 |
| 187Running tests 188============= 189 190Before posting a change to the code review site, you should always run the 191quick tests! 192See TESTING.md for more information. 193 |
|
| 181Posting a review 182================ 183 184If you have not signed up for an account on the Gerrit review site 185(https://gem5-review.googlesource.com), you first have to create an account. 186 187Setting up an account 188--------------------- --- 152 unchanged lines hidden --- | 194Posting a review 195================ 196 197If you have not signed up for an account on the Gerrit review site 198(https://gem5-review.googlesource.com), you first have to create an account. 199 200Setting up an account 201--------------------- --- 152 unchanged lines hidden --- |